this post was submitted on 16 Nov 2023
314 points (99.1% liked)

Programmer Humor

19480 readers
173 users here now

Welcome to Programmer Humor!

This is a place where you can post jokes, memes, humor, etc. related to programming!

For sharing awful code theres also Programming Horror.

Rules

founded 1 year ago
MODERATORS
 
you are viewing a single comment's thread
view the rest of the comments
[–] [email protected] 23 points 11 months ago (2 children)

The worst case is when someone requires changes, you address them, but then they disappear/go on a leave.

If the repository rules require all conversations to be resolved before merging and only the original reviewer can mark them as solved, the PR is stuck forever even if the rest of the team approves it.

[–] [email protected] 9 points 11 months ago (1 children)

That sounds like something you bring up in the retro

[–] [email protected] 3 points 11 months ago (1 children)

When the person came back from the leave I made some passive aggressive remark, hope this is enough 🤣

[–] [email protected] 3 points 11 months ago

Have you tried ignoring their PRs for a few weeks?

[–] [email protected] 5 points 11 months ago (1 children)

At that point, you get your team lead to go in the repo settings and unblock it.

[–] [email protected] 1 points 11 months ago

Plot twist: it’s the team lead who goes on a leave